make regex PCRE2 compliant

robrichards / xmlseclibs

A PHP library for XML Security

BSD 3-Clause "New" or "Revised" License

388 stars 181 forks source link

Closed restena-sw closed 5 years ago

restena-sw commented 6 years ago

PHP7.3 makes a hard switch from PCRE to PCRE2, where the hyphen needs to be escaped. I've tested and confirmed that with PHP 7.3rc3

the code as was before this PR breaks with a PHP error about unable to compile the regex
the code with this one-character PR applied works just fine

thijskh commented 5 years ago

@robrichards Thanks for merging, can you tag 3.0.3? This means that dependent projects like simplesml can start automated testing against 7.3 aswell.

robrichards commented 5 years ago

Done