Encryption certificate inclusion

robrichards / xmlseclibs

A PHP library for XML Security

BSD 3-Clause "New" or "Revised" License

388 stars 181 forks source link

Encryption certificate inclusion #224

Open SharkMachine opened 3 years ago

SharkMachine commented 3 years ago

Adds the possibility to include encryption certificate with with xenc:EncryptedData/dsig:KeyInfo/xenc:EncryptedKey/dsig:KeyInfo/dsig:X509Data/dsig:X509Certificate

nicodemuz commented 3 years ago

Looks great! Can we get this merged in? @robrichards

SharkMachine commented 2 years ago

@robrichards I have to use a fork of this library because these changes are needed for web services to Danske Bank to work.

robrichards commented 2 years ago

@SharkMachine Thinking about the logic a bit as it does change the current behavior slightly. Now you must pass in includeKeyInfo as true for it to include the name whereas before as long as the key name was not empty it would add it. Would prefer to keep the existing behavior while also adding this as to avoid any BC issues