search

robrix / Madness

Recursive Descent Into Madness
MIT License
291 stars 17 forks source link

Fix number parser #109

Closed bencochran closed 8 years ago

bencochran commented 8 years ago

The number parsing was having trouble with greedy matching (int matched before decimals, decimals before decimals with exponents, and “e” before “e+”). This fixes all that and adds a slew of tests.

robrix commented 8 years ago

Whoa, thank you so much!

@joshvera: would you mind taking a quick glance at this?

joshvera commented 8 years ago

Looks good. Thanks @bencochran!

robrix commented 8 years ago

@joshvera: Thanks :blush:

@bencochran: I’ve added you as a collaborator. PRs are still preferred for non-trivial changes, but it should be a little more convenient now :blush:

Thanks again!

bencochran commented 8 years ago

@joshvera Thanks for the merge!

@robrix Thanks for adding me :bow: