Some Combinators - Githubissues

robrix / Madness

Recursive Descent Into Madness

MIT License

291 stars 14 forks source link

Some Combinators #113

Closed 335g closed 8 years ago

335g commented 8 years ago

This PR provides some combinators.

between
manyTill
endBy1
endBy

I worried whether I PR, because of no contributing guide. I would be happy if you could review this with whether these combinators are necessary. I close this PR, if necessary not. :bow:

robrix commented 8 years ago

Thank you very much for the PR! :bow:

robrix commented 8 years ago

This is lovely, thank you again for the PR! I’ve made a few minor notes above, but please consider all of my feedback open to discussion—I’d appreciate hearing your thoughts about any/all of it.

335g commented 8 years ago

Thanks review. I fixed it :+1:

I think that this implementation may be from merged #89, but I PR because I think that it is necessary too. I'm glad if I can contribute even a little :satisfied:

robrix commented 8 years ago

Great stuff, thank you so much!

335g commented 8 years ago

:bow: