search

robrotheram / taiga-contrib-openid-auth

Taiga plugin for openid authentication
45 stars 25 forks source link

make docker image smaller and more robust #40

Closed ibotty closed 2 years ago

lennardk commented 2 years ago

I'm not sure pip install -e-ing from /tmp is a very sensible thing to do, as all pip install -e does is create site-packages/easy-install and site-packages/taiga-contrib-openid-auth.egg-link, both pointing to the /tmp path

ibotty commented 2 years ago

No, it installs in /opt/venv/lib/python3.7/site-packages. You are kind-of right. I am not very familiar with pip. Does pip install without -e the right thing: copying to the site-path?

I used -e because the original image was using it.

lennardk commented 2 years ago

I think pip install /tmp/taiga-contrib-openid-auth*/back && rm -R /tmp/taiga-contrib-openid-auth* would do the trick yes, although I haven't tested it myself.

ibotty commented 2 years ago

What do you think? I am running a container built like this (but based on some pull requests on the taiga-docker repos) in production.

lennardk commented 2 years ago

looks good to me, but I'm not a maintainer. @ralphbean looks like the right person to accept :)