search

robscott / kube-capacity

A simple CLI that provides an overview of the resource requests, limits, and utilization in a Kubernetes cluster
Apache License 2.0
2.13k stars 115 forks source link

refactor: Add option struct to optimize parameter transfer #112

Closed Forget-C closed 8 months ago

Forget-C commented 8 months ago

Add option struct to optimize parameter transfer

Affect user experience： false

isaacnboyd commented 8 months ago

Very cool! This will have conflict with a few of the open PRs as they are all new feature flags. Will need a good rebase after PRs 109, 110, and 113 are merged.

Forget-C commented 8 months ago

Thanks @Forget-C! This is a great improvement that has been long overdue. Just a tiny nit on naming but otherwise LGTM.

Thank you for your advice. I modified the naming and merged with the master branch

robscott commented 8 months ago

Thanks @Forget-C!