FIX PR #98 -- advanced node taint querying

robscott / kube-capacity

A simple CLI that provides an overview of the resource requests, limits, and utilization in a Kubernetes cluster

Apache License 2.0

2.06k stars 113 forks source link

FIX PR #98 -- advanced node taint querying #113

Closed isaacnboyd closed 5 months ago

isaacnboyd commented 6 months ago

PR #98 required:

Rebasing #98 branch on main and resolving numerous conflicts, especially in the capacity tests (please review)
Cleaning lint (no return value on splitTaint() and goformatting)
Testing new feature and adding instructions in README

resolves #91 closes #98

robscott commented 5 months ago

Hey @isaacnboyd, let me know if you think you'll have some time to work on this in the next week or so. Largely thanks to all your great improvements, I think it's probably close to time to cut another release (probably v0.8.0), but don't want this to miss the cut if you've got plans to work on it sometime soon.

isaacnboyd commented 5 months ago

Hey @isaacnboyd, let me know if you think you'll have some time to work on this in the next week or so. Largely thanks to all your great improvements, I think it's probably close to time to cut another release (probably v0.8.0), but don't want this to miss the cut if you've got plans to work on it sometime soon.

Hey howdy Rob, yes I'd like to get this one into the release. I should be able to find some time to work on it here in the next few days.

robscott commented 5 months ago

Thanks @isaacnboyd! Just let me know whenever it's ready for another round of review (or if it already is).

isaacnboyd commented 5 months ago

Thanks @isaacnboyd! Just let me know whenever it's ready for another round of review (or if it already is).

Hey @robscott this is ready for another review.

robscott commented 5 months ago

Thanks @isaacnboyd!