zvezdan
commented
6 years ago This dependency needs to be declared conditionally for python 2.7 only using environment markers. There are several options here:
enum34 ; python_version<'3'This is the most straightforward way. You can also use =='2.7' or <3.4, which based on the versions of Python already supported by pyangbind are equivalent to the above marker.
Notice that this kind of setting requires a recent version of setuptools (>=36.2) because markers were not allowed in install_requires before that. Since setup.py has code in it that processes requirements.txt and puts them in install_requires, the new markers syntax in them would demand the use of recent setuptools.
If pyangbind developers want to make sure that it can be built with older version of setuptools, then the approach must be different. The code that reads requirements.txt would have to exclude any lines that have a semicolon in them (markers present) and put those entries in extras_require instead of install_requires. The format in that case would be:
extras_require={
":python_version<'3'": ['enum34'],
}This would work with setuptools>=18.0.
This should be easy to fix and ensure that pyangbind produces correct Python package metadata.
tarkatronic
kqchen34
ApheleiaS
robshakir
jvleminc
JoseIgnacioTamayo
If enum34 is a requirement of pyangbind, then pyangbind would not be able to support Python 3.6 / 3.7, since the lib enum34 is not compatible with Python 3.6 and later versions.
E.g. when I try to run an application in python 3.7 with pyangbind imported, I got the following error: Traceback (most recent call last): File "bin/generate_yang_modules", line 49, in
import app_scripts.generate_yang_modules
File "/bbnet/home/kchen34/git/bnop_driver/app_scripts/init.py", line 2, in
import("pkg_resources").declare_namespace(name)
File "/bb/bin/package/p/python3.7-venv-bnop/1.0.1+b20181029T17473333/libexec/python3.7-venv-bnop/lib/python3.7/site-packages/pkg_resources/init.py", line 24, in
import re
File "/bb/sys/package/p/python3.7-venv-bnop/1.0.1+b20181029T17473333/libexec/python3.7-venv-bnop/lib/python3.7/re.py", line 143, in
class RegexFlag(enum.IntFlag):
AttributeError: module 'enum' has no attribute 'IntFlag'