search

robshakir / pyangbind

A plugin for pyang that creates Python bindings for a YANG model.
Other
203 stars 121 forks source link

Remove Integration tests that use /bgp #330

Closed JoseIgnacioTamayo closed 9 months ago

JoseIgnacioTamayo commented 10 months ago

Remove Integration tests that use /bgp

/bgp was removed since https://github.com/openconfig/public/commit/eabe9951115ddfe310b4913fc429a92732645976

The test objective is acomplished already with openconfig-interfaces model at /interfaces

Fixes https://github.com/robshakir/pyangbind/issues/305

robshakir commented 9 months ago

You could move these to use /network-instances/network-instance/protocols/protocol/bgp -- since it seems advantageous not to lose coverage. If there's duplication though, seems fine to remove them.

JoseIgnacioTamayo commented 9 months ago

Hi there,

Thanks for your inputs.

Although it is good to keep coverage, as I interpret these tests, they just ensure that an OpenConfig Yang model can be bound and used to produce a valid JSON blob. This objective is already accomplished with the tests that use openconfig-interfaces.

With that rationale, I think we can drop these tests.

Saludos / Best regards / Cordialement,

Jose Ignacio Tamayo Segarra LinkedIn http://br.linkedin.com/in/joseignaciotamayosegarra

On Thu, Dec 14, 2023 at 5:41 AM Rob Shakir @.***> wrote:

You could move these to use /network-instances/network-instance/protocols/protocol/bgp -- since it seems advantageous not to lose coverage. If there's duplication though, seems fine to remove them.

— Reply to this email directly, view it on GitHub https://github.com/robshakir/pyangbind/pull/330#issuecomment-1855118793, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAWOWLQHQP2REC5UMC337TYJJ7ORAVCNFSM6AAAAABAHWBZN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJVGEYTQNZZGM . You are receiving this because you authored the thread.Message ID: @.***>