search

robshep / logback-logdna

A Logback appender for shipping logs to LogDNA
MIT License
14 stars 9 forks source link

Fixed fields or tags #4

Open robshep opened 6 years ago

robshep commented 6 years ago

Two recent pull requests deal with a similar topic.

(Thank you for the contributions)

The first one from @TheConnMan #1 uses regular free form KEY=VALUE "addtionalFields" set in XML

The second one from @tomreay #2 uses comma separated tags VAL1,VAL2,VAL3 "tags" set in XML.

They both seem to achieve the same thing, but my preference is for #1 as this seemst to achieve #2's aims also.

Does the tags URL param provide any different level of functionality to payload metadata

Discuss.

(thanks again to both)

TheConnMan commented 6 years ago

I usually add multiple key/value pairs, so I prefer that to only tags.

tomreay commented 6 years ago

These actually achieve very similar looking but slightly different things (I think, I'm not a LogDNA expert!)

1 Allows setting of custom attributes in the meta object, allowing you to search/filter on them in the log viewer. This could be used for many things.

screen shot 2018-03-20 at 10 03 17

2 Allows setting of the tags attribute of the POST request that sends the logs to LogDNA, I use this to separate out test and production:

https://docs.logdna.com/docs/api

screen shot 2018-03-20 at 10 03 30

My vote is to merge both and try and make the difference clear in the docs

TheConnMan commented 6 years ago

I see, interesting that there's another conventional param (and that it's a request param). So tags are meta-like fields but get their own top level dropdown?

tomreay commented 6 years ago

I think it's because you might want to put a whole manner of things into the metadata - anything you might want to search on. But you probably only want a few things in a top level dropdown

TheConnMan commented 6 years ago

So are both of these PRs valuable in their own way? Is it worth merging both?

tomreay commented 6 years ago

I think it's worth merging both - yes

TheConnMan commented 1 year ago

Hello from the future. Is there any interest in merging these?

robshep commented 1 year ago

Hi, I'm no longer using LogBack and have no time/energy to maintain this. Do you want to maintain? I'll happily transfer the repo. Rob

TheConnMan commented 1 year ago

Unfortunately, I also don't use this anymore either. I came across this PR when I was cleaning out GitHub. I'll close mine out.