robske110 / TicTacToe

Play TicTacToe with the help of item frames.
https://poggit.pmmp.io/p/TicTacToe
GNU Lesser General Public License v3.0
6 stars 3 forks source link

critical #12

Closed ghost closed 4 years ago

ghost commented 6 years ago

sometimes when the player touches the itemframe trying to play normally it doesn't replace the ingot and this error comes up in the console:

Could not pass event 'pocketmine\event\player\PlayerInteractEvent' to 'TicTacToe v0.1.4': Invalid argument supplied for foreach() on robske_110\TTT\EventListener 17.04 18:45:24 [Server] Server thread/CRITICAL ErrorException: "Invalid argument supplied for foreach()" (EXCEPTION) in "TicTacToe-master/src/robske_110/TTT/Game/Game" at line 155

also the winner gets the lose message instead of the win message .

(using the latest 1.0.0dev branch)

robske110 commented 6 years ago

does this happen after the game has ended? (so the player clicks on the frame while the game was already won?) Also, a stack trace would be really appreciated! (And steps to reproduce)

ghost commented 6 years ago

no its when in game , i saw them too , he taps on the itemframe while holding the item but it doesn't place it there and i check the console and i see that error,

the problem here is that it can't be reproduced cuz it somehow happens after a few games ,

also sometimes some players are unable to play , like they play some games and then when they press the sign it says they joied the queue but when other players touch the sign it makes them join a game but that player doesn't, so now he has to quit and rejoin to be able to plau again , no errors for this one but i think its caused for those who get the error above?

ghost commented 6 years ago

CRITICAL]: Could not pass event 'pocketmine\event\player\PlayerInteractEvent' to 'TicTacToe v0.1.4': Undefined offset: -1 on robske_110\TTT\EventListener
2018-04-17 [14:14:59] [Server thread/CRITICAL]: ErrorException: "Undefined offset: -1" (EXCEPTION) in "TicTacToe-master/src/robske_110/TTT/Game/Game" at line 266
2018-04-17 [14:14:59] [Server thread/DEBUG]: #0 TicTacToe-master/src/robske_110/TTT/Game/Game(266): pocketmine\error_handler(integer 8, string Undefined offset: -1, string /home/minecraft/multicraft/servers/server21218/plugins/TicTacToe-master/src/robske_110/TTT/Game/Game.php, integer 266, array Array())
2018-04-17 [14:14:59] [Server thread/DEBUG]: #1 TicTacToe-master/src/robske_110/TTT/Game/Game(145): robske_110\TTT\Game\Game->end(integer -1)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #2 TicTacToe-master/src/robske_110/TTT/Game/Game(57): robske_110\TTT\Game\Game->checkForWin()
2018-04-17 [14:14:59] [Server thread/DEBUG]: #3 TicTacToe-master/src/robske_110/TTT/EventListener(29): robske_110\TTT\Game\Game->onGameMove(integer 11, pocketmine\block\ItemFrame object, pocketmine\item\Item object)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #4 src/pocketmine/plugin/MethodEventExecutor(38): robske_110\TTT\EventListener->onItemFrameItemSet(pocketmine\event\player\PlayerInteractEvent object)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #5 src/pocketmine/plugin/RegisteredListener(98): pocketmine\plugin\MethodEventExecutor->execute(robske_110\TTT\EventListener object, pocketmine\event\player\PlayerInteractEvent object)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #6 src/pocketmine/plugin/PluginManager(683): pocketmine\plugin\RegisteredListener->callEvent(pocketmine\event\player\PlayerInteractEvent object)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #7 src/pocketmine/level/Level(1851): pocketmine\plugin\PluginManager->callEvent(pocketmine\event\player\PlayerInteractEvent object)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #8 src/pocketmine/Player(2286): pocketmine\level\Level->useItemOn(pocketmine\math\Vector3 object, pocketmine\item\Item object, integer 2, pocketmine\math\Vector3 object, TheNewHEROBRINE\Murder\entity\MurderPlayer object, boolean 1)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #9 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(132): pocketmine\Player->handleInventoryTransaction(CortexPE\network\InventoryTransactionPacket object)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #10 TeaSpoon-master/src/CortexPE/network/InventoryTransactionPacket(151): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleInventoryTransaction(CortexPE\network\InventoryTransactionPacket object)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #11 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): CortexPE\network\InventoryTransactionPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/protocol/BatchPacket(115): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(CortexPE\network\InventoryTransactionPacket object)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #13 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #14 src/pocketmine/Player(2964): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2018-04-17 [14:14:59] [Server thread/DEBUG]: #15 src/pocketmine/network/mcpe/RakLibInterface(149): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)```
robske110 commented 6 years ago

please try to reproduce this error with the latest commit on the 1.0.0-InDev branch. (with debug enabled in pocketmine.yml) It will dump a lot of useful information for me.

robske110 commented 6 years ago

any news?

ghost commented 6 years ago

im currently on standby once the issue occurs I will send the informations here , (its either the issue no longer happens or the players didn't report it again yet)

robske110 commented 6 years ago

no news still?

robske110 commented 6 years ago

will close this issue in the next few days due to inactivity