search

robske110 / TicTacToe

Play TicTacToe with the help of item frames.
https://poggit.pmmp.io/p/TicTacToe
GNU Lesser General Public License v3.0
6 stars 3 forks source link

Using players ID in player manager is not a good practice #3

Closed Yexeed closed 6 years ago

Yexeed commented 6 years ago

Because, when players rejoin, their ID is changing. So it will be really good to move to player names instead of IDs

robske110 commented 6 years ago

This plugin doesn't use the ids for any saving stuff. It just uses them to identify a player in one session. After a player leaves, they get removed from the PlayerManager: https://github.com/robske110/TicTacToe/blob/master/TicTacToe/src/robske_110/TTT/EventListener.php#L91 I did find a small bug though while looking at the removal code...