search

robsontenorio / laravel-keycloak-guard

🔑 Simple Keycloak Guard for Laravel
MIT License
434 stars 141 forks source link

Improve ActingAsKeycloakUser trait #114

Closed elnurvl closed 5 months ago

elnurvl commented 6 months ago

The aim of the change is to allow passing custom claims to the test token as well as adding widely accepted claims by default.

elnurvl commented 6 months ago

@robsontenorio , is it possible that we can make a progress here? I have noticed the PR is open for over a week but there is no response. I'd be happy to make necessary adjustments if you have any concern regarding merging the PR.

To be clear, due to the lack of customizing the token payload the library becomes unusable in certain projects where the exact token payload is being asserted.

robsontenorio commented 6 months ago

Please , include tests and update the README if needed.

@tuytoosh could you please review it?

elnurvl commented 6 months ago

@robsontenorio , done. @tuytoosh , please note I have also made some change to use the configured db column instead of hard-coded username. Let me know if you don't agree with anything.

hamidhaghdoost commented 5 months ago

Sorry for the late feedback. From my point of view, it is quite OK to be merged.

robsontenorio commented 5 months ago

Thanks guys !