search

robsontenorio / laravel-keycloak-guard

🔑 Simple Keycloak Guard for Laravel
MIT License
434 stars 141 forks source link

Prepare to update all #77

Closed robsontenorio closed 2 years ago

robsontenorio commented 2 years ago

Resolves #75 #70 #66 #67 #63 #64

Inspired by #75 . Big thansks to @Nizari effort !

Just opted to not include all boilerplate from #75 in order to keep things simple. After this MR I am able to review anothers MRs.

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fe6b9c5). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             master       #77   +/-   ##
==========================================
  Coverage          ?   100.00%           
  Complexity        ?        32           
==========================================
  Files             ?         4           
  Lines             ?        87           
  Branches          ?         0           
==========================================
  Hits              ?        87           
  Misses            ?         0           
  Partials          ?         0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Nizari commented 2 years ago

Resolves #75 #70

  • Update all dependencies
  • Add leeway option to prevent token excepetion due to network issues
  • Add phpcsfixer
  • Add github actions
  • Add VSCODE devcontainer
  • Update README

Inspired by #75 . Big thansks to @Nizari effort !

Just opted to not include all boilerplate from #75 in order to keep things simple. After this MR I am able to review anothers MRs.

Haha I can understand that ;) you can close my PR when you want. Nice that you kept the phpcsfixer!

robsontenorio commented 2 years ago

@Nizari I have solved many gotchas after updating versions by looking up your MR

AubreyHewes commented 2 years ago

Wow, Just seeing this now. Why did you incorporate the PRs as own changes?

This removes the opensource idea of contributing to a project. If people take the changes for themselves.

There is no excuse. Make an integration branch merge all the PRs.. Then change what you want. This way all are still credited for actually helping the project.

AubreyHewes commented 2 years ago

Also never commit everything with "WIP".. say what you are doing as it explains the code changes i.e. took this from so and so PR. Doing this because of this PR.. etc.

Conventional commits explains this better.

Also if WIP why commit and push so much? Just push when the WIP is done? Locally can reset head etc.

AubreyHewes commented 2 years ago

All in all I am disappointed I actually cared/took the time to give a PR to this project. I don't need the credit.. but when work I have done is taken by someone else.. then yeah I get annoyed.