search

robswc / tradingview-webhooks-bot

a framework 🏗 for trading with tradingview webhooks!
http://tvwb.robswc.me
GNU General Public License v3.0
620 stars 185 forks source link

Conflict Jinga vs flask in requirements #60

Closed dorienh closed 1 year ago

dorienh commented 1 year ago

Just tried installing from repo but there is a conflict with dependencies: 

The conflict is caused by:
    The user requested Jinja2==3.1.1
    flask 2.3.2 depends on Jinja2>=3.1.2

updating one dependency led to another conflict. Finally, this set worked, but I'm hoping nothing broke... 

click==8.1.3
colorama==0.4.5
Flask==2.3.2
gunicorn==20.1.0
itsdangerous==2.1.2
Jinja2==3.1.2
MarkupSafe==2.1.1
shellingham==1.4.0
typer==0.4.0
typer-cli==0.0.13
Werkzeug==2.3.3

Update: yes, when I try to run, I notice the following error:

cannot import name 'get_terminal_size' from 'click.termui'

robswc commented 1 year ago

ah yea, that's not good! Thanks for letting me know! I saw there was a big security issue with Flask but I suppose since this isn't a public facing project anyways, I'll downgrade it back to what it was before.

robswc commented 1 year ago

@dorienh I've gone and upgraded the dependencies, it should be working now!

Let me know if there's any issues!

https://github.com/robswc/tradingview-webhooks-bot/pull/63