Improve heartbeat - Githubissues

robtaussig / react-use-websocket

React Hook for WebSocket communication

MIT License

1.63k stars 135 forks source link

Improve heartbeat #246

Closed w666 closed 1 month ago

w666 commented 1 month ago

Use one timer instead of two
Do not re-initialise timer when new message received
Start heartbeat when WS connection established
Store epoch time when last message was received, only send heartbeat messages when there is no traffic
Update tests to reflect changes

w666 commented 1 month ago

Tests are pretty much unchanged, so it is still backward compatible. But heartbeat implementation makes more sense now.

w666 commented 1 month ago

@robtaussig, is there a chance to review this and maybe even merge and build a release? Thanks.

robtaussig commented 1 month ago

Ahh, apologies! It’s been on my list to review this — thank you for checking in and especially for contributing. Will review as soon as I’m home today!

robtaussig commented 1 month ago

Merged and published as 4.10.0! Thanks again!