robulouski / voidy-bootstrap

A Pelican theme based on Bootstrap. A modern mobile-friendly theme using Bootstrap 3 and FontAwesome 4.
http://www.voidynullness.net/page/voidy-bootstrap-pelican-theme/
MIT License
66 stars 26 forks source link

Add copyright to footer using Author #4

Closed kastl closed 9 years ago

kastl commented 9 years ago

Adding a copyright to the site. Code from pelican-bootstrap3 theme. This would allow a copyright without having to change the theme. Other themes like pelican-bootstrap3 already do this.

robulouski commented 9 years ago

Thanks for your interest in this theme...but I have some concerns about this change, minor as it may be.

My main concern is that it's already possible to add a copyright notice without modifying the theme templates -- by using the CUSTOM_FOOTER setting. That's kind of what it's there for. Unless I'm missing something, is there any reason you couldn't accomplish pretty much the same thing using CUSTOM_FOOTER?

I realise it's not quite the same thing, it's a little bit more work because you'd have to add your own custom template fragment. But the advantage is a lot more flexibility, because CUSTOM_FOOTER allows users of the theme to put whatever content they like in the footer area, not just a copyright notice.

kastl commented 9 years ago

I agree that the custom footer would work if I could simply put the entire footer into it. I would like to put this snippet in there (please see source to see actual html): ---start----

{% include 'includes/' + CUSTOM_FOOTER|default('footer.html') ignore missing %} {% if articles %} {% set copy_date = articles[0].date.strftime('%Y') %} {% else %} {% set copy_date = '' %} {% endif %}

© {{ copy_date }} {{ AUTHOR }} · Site built using Pelican  •  Theme based on VoidyBootstrap by RKI

---end--- When I do that and try to rebuild the site I get this error: root@ebacfdd76868:~/blog# make html pelican /root/blog/content -o /root/blog/output -s /root/blog/pelicanconf.py CRITICAL: maximum recursion depth exceeded make: *\ [html] Error 1

robulouski commented 9 years ago

Try this in your footer template:

<!-- START FOOTER TEMPLATE -->
<div class="container">
{% if articles %}
{% set copy_date = articles[0].date.strftime('%Y') %}
{% else %}
{% set copy_date = '' %}
{% endif %}

&copy; {{ copy_date }} {{ AUTHOR }}
</div>
<!-- END FOOTER TEMPLATE -->
kastl commented 9 years ago

It technically satisfies the ability to put the copyright in the footer. But it doesn't look right since it is placed on a separate line from the rest of the existing footer which is provided by default. Many sites have the copyright at the bottom of the site. It's also not user friendly if you only want a copyright added. That's my only customization of the theme, for example.

robulouski commented 9 years ago

Since that worked I'm going to close this.

It's obviously a subjective thing, but personally I think it looks fine. In fact, I like it better on a separate line (that's how I implemented it on my blog). Note that you are free to style the footer content however you see fit with CSS.

I think we also have a different idea of what constitutes a "footer". I don't really think of the "powered by Pelican" line as the footer content, as such. In the code I've called it a colophon, for want of a better term, but that's not really the right word. I think of that line as part of the theme scaffolding, so it doesn't really make sense to me to put any other content right next to it, and certainly not as the default behaviour. Even something as mundane as a copyright notice is semantically part of the blog content, not the theme, so it makes more sense to me that it's visually distinct from theme artefacts.

Users of the theme are free to do whatever they want, but in my opinion the CUSTOM_FOOTER setting as currently implemented is adequate enough for a simple copyright notice, while being flexible enough to allow for adding far more complex footer content.