Custom mac address - Githubissues

robur-coop / albatross

Albatross: orchestrate and manage MirageOS unikernels with Solo5

ISC License

141 stars 17 forks source link

Custom mac address #107

Closed reynir closed 1 year ago

reynir commented 2 years ago

This PR extends the --net command line argument to take an optional mac address separated by an ampersand. The format is --net=service:bridge@00:11:22:33:44:55.

Things to do:

[x] Fix pretty printing of optional mac address.
[x] Fix the ASN.1. I'm confused how much backwards compatibility we need.
[x] Actually pass --net-mac to solo5.
[ ] ~~Consider how it fits in with the resource policies. Likely, we want to be able to put restrictions on the use of custom mac addresses.~~

reynir commented 2 years ago

It occurred to me that we would want to be able to impose a policy on custom mac addresses. Especially in a multi-tenant setup. As a first iteration a binary 'allow all/disallow custom mac' is probably fine. Added a sub task for it.

hannesm commented 1 year ago

I rebased. What we have now in the main branch are some tests (even with the old wire format) that are still passing.

I reverted the introduction of v3_unikernel_config, since the change is backwards compatible (an optional non-ambiguous field was added to the sequence).

hannesm commented 1 year ago

May be sensible to add a test with a unikernel that has a mac address specified.

hannesm commented 1 year ago

about resource policies: since tenants can be restricted to bridges, that's sufficient -- it is anyways the case that any unikernel can send out any ethernet frames... so nothing to worry about