robur-coop / albatross

Albatross: orchestrate and manage MirageOS unikernels with Solo5
ISC License
142 stars 17 forks source link

Make albatross-provision one binary #159

Closed reynir closed 1 year ago

reynir commented 1 year ago

albatross-provision has subcommands ca and request that serve the same purpose as albatross-provision-ca and albatross-provision-request respectively.

The binary is about the same size as either of the previous binaries. In the (compressed) debian package this results in a further ~3MB reduction of size.

hannesm commented 1 year ago

hmm, this leads to quite wordy invocations "albatross-provision ca sign" -- why not flatten that, "albatross-provision sign"?

reynir commented 1 year ago

That's a good point. I chose this way out of laziness as it seemed to me to require touching less of the code. But I like merging the commands.

hannesm commented 1 year ago

I took the liberty to rebase and merge the subcommands into albatross-provision (as remarked above).