search

robur-coop / albatross

Albatross: orchestrate and manage MirageOS unikernels with Solo5
ISC License
142 stars 17 forks source link

Influx/metrics: fix typo (cow_faul[t]s), avoid empty tag name for root domain #182

Closed hannesm closed 3 months ago

hannesm commented 3 months ago

Also avoid reporting empty measurements

I can see on our mirage host:

Jul  1 12:44:32 infra-2 telegraf[86143]: 2024-07-01T12:44:32Z E! [inputs.socket_listener] Error in plugin: parsing error: metric parse error: expected field at 1:24: "kinfo_mem,vm=albatross "
Jul  1 12:44:32 infra-2 telegraf[86143]: 2024-07-01T12:44:32Z E! [inputs.socket_listener] Error in plugin: parsing error: metric parse error: expected tag at 1:36: "vmm-unikernels,vm=albatross,domain= attached\\ used\\ block=0i,unattached\\ used\\ block=0i,total\\ used\\ block=0i,running\\ unikernels=4i,used\\ memory=1216i"

I still don't fully understand how the kinfo_mem,vm=albatross comes into play. But protecting the albatross daemon to report empty measurements may be a good idea in any case.