Closed reynir closed 3 years ago
this mostly looks fine - thanks for doing it.
I'm wondering that now the information about which socket name is used is in systemd (and the services are started accordingly). This also means that albatross_daemon that requires albatross_console.socket should take the socket name as argument, or not?
With this PR, the albatross_daemon will still use the hardcoded path from tmpdir/util/console.sock
(as written in socket_path
function in src/Vmm_core) -- does this matter (certainly not for a standard installation, but for someone who wants to modify the socket paths that makes a difference since they may think that they'd only need to adapt the systemd scripts)? Maybe a sentence in the Linux installation instructions is sufficient to not worry about that potential issue.
thanks a lot, merged
This PR is just to keep track.
Things to be done:
sd_listen_fds
so we don't depend on the Linux-specificocaml-systemd
. Or some other way around this issue.