improve block handling:

robur-coop / albatross

Albatross: orchestrate and manage MirageOS unikernels with Solo5

ISC License

142 stars 17 forks source link

improve block handling: #67

Closed hannesm closed 3 years ago

hannesm commented 3 years ago

Vmm_resources.check_vm needs to check for the right block device
the solo5-hvt/spt argument is --block:<>=<>, not --disk
Vmm_tls: allow block commands
Vmm_unix.find_block_devices creates dbdir / block_sub if it does not exist (previously, this lead to a crash of albatrossd)

In addition, Vmm_resources.check_policy returns more detailed error messages.

hannesm commented 3 years ago

The Linux packaging script could be updated to not create the block directory

right, there's the question what the packaging scripts should do, and what albatrossd should do. I'm also fine with relying on packaging scripts to create the necessary directories -- but nevertheless albatrossd should check their existence and complain (instead of fail via an exception) if the on-disk layout / permissions are not suitable for its operations.

hannesm commented 3 years ago

I revised this PR, and think it is good to be merged now. The FreeBSD installation script now creates the block directory, and any invocation of "create_block" ensures the block directory to be present (otherwise, it is created with permissions 700).