Add optional platform argument to builder-client execute

robur-coop / builder

Scheduling build jobs on regular intervals, collecting artifacts

ISC License

13 stars 1 forks source link

Add optional platform argument to builder-client execute #25

Closed reynir closed 2 years ago

reynir commented 2 years ago

Furthermore, builder-client execute doesn't reschedule the job since the semantics becomes exotic when executing a job on one platform and rescheduling the job.

Keeping it a draft for now because add_to_front_of_queues has become rather complicated.

hannesm commented 2 years ago

This looks mostly good, I'm curious if we do:

let* j = find_job job_name in
let* queues_to_modify = find_queues platform j in
t.queues <- SM.map recreate_queue queues_to_modify;
Lwt_condition.broadcast t.waiter

so, basically, have a second small function (next to find_job) find_queues that returns a (queue list, [> `Msg of string ]) result?