search

robur-coop / builder

Scheduling build jobs on regular intervals, collecting artifacts
ISC License
13 stars 1 forks source link

worker: use timeout of 1 hour #28

Closed hannesm closed 1 year ago

hannesm commented 1 year ago

//cc @reynir AFAICT Linux and BSD support timeout 1h.... we could as well use some fancy Lwt or another process, but I fear that'd make the worker way more complex than is good.

hannesm commented 1 year ago

the server as well has a timeout for each worker, and I wonder whether it nicely shuts off all sockets (or leaks the resources). should investigate.

the worker does not read anything from the server once the command has been transferred, thus the server just saying "timeout exceeded" won't solve the worker issue AFAICT

hannesm commented 1 year ago

We could as well try extend the server-worker protocol and have the server send a Timeout message or similar. It would make the worker code more complicated.

Yes, it would also not solve the issue. Since a server may disappear...