search

robur-coop / builder

Scheduling build jobs on regular intervals, collecting artifacts
ISC License
13 stars 1 forks source link

Use /job/_/build/_/main-binary alias #42

Closed reynir closed 1 month ago

reynir commented 5 months ago

This is useful for bootstrapping as the /job/_/platform/_/upload defaults to using <job-name>.bin for the main binary if the user forgets to pass the undocumented ?binary_name query parameter when uploading a binary manually. This alias has been in builder-web for quite a while now.

The downside is if a change in main binary name is intentional; then this change hides this fact.

hannesm commented 5 months ago

To me this looks great. Feel free to merge when you're satisfied with it. :)

hannesm commented 1 month ago

this looks straightforward, is this change desired @reynir? if yes, let's merge :)

reynir commented 1 month ago

Yes! I think I just forgot about it -- oops!