robur-coop / builder

Scheduling build jobs on regular intervals, collecting artifacts
ISC License
13 stars 1 forks source link

execute also has interesting semantics #46

Closed hannesm closed 2 months ago

hannesm commented 2 months ago

My expectation was that execute would also push the schedule. if I have a schedule to execute a job on a daily basis, and a job that is executed at 14:00 daily, if I do an execute at 18:00, my expectation was that in the future the job would be scheduled at 18:00.

Does this sound like a good plan?

reynir commented 2 months ago

Hmm. There is already builder-client reschedule. Maybe we can add a execute --reschedule-now or so, or reschedule --execute-now? If a build fails due to something that needs fixing it can be nice to execute without rescheduling after you've pushed a fix if you're otherwise happy with the schedule (e.g. low energy prices or high percentage of renewable energy available).

In short: I think it is worth adding this new semantics while keeping the old semantics. Either could be behind a flag.

hannesm commented 2 months ago

Another approach is to introduce another subcommand ;)

But maybe given that reschedule exists, that's fine. I keep on forgetting about reschedule.

hannesm commented 2 months ago

closing since we have reschedule, the semantics of execute as is are useful, and there's other things to spend our time on.