search

robur-coop / builder

Scheduling build jobs on regular intervals, collecting artifacts
ISC License
13 stars 1 forks source link

Check for integer overflow #50

Open reynir opened 2 weeks ago

reynir commented 2 weeks ago

In Builder.read there's a conversion from int64 to int where we should check for integer overflow. There is a (* TODO *) at the location though without further explanation.

https://github.com/robur-coop/builder/blob/e3c5d9389652f99d6ff3abbd889a325d5d7d3362/lib/builder.ml#L556-L558

hannesm commented 2 weeks ago

Same code path (using Lwt) is in app/server.ml. Same issue applies there, same (*TODO*).