search

robur-coop / happy-eyeballs

An implementation of happy eyeballs (RFC 8305) in OCaml with lwt
ISC License
22 stars 4 forks source link

Relax OCaml lower bound to support >= 4.08 #16

Closed smorimoto closed 2 years ago

smorimoto commented 2 years ago

As the title says.

smorimoto commented 2 years ago

This PR is intended to address the following an error that is not actually true when attempting to use conduit-mirage with OCaml >= 4.08 && < 4.10:

conduit-mirage >= 5.0.0 → dns-client >= 6.0.0 → happy-eyeballs >= 0.0.6 → ocaml >= 4.10.0
hannesm commented 2 years ago

thanks for your PR, may I ask why you can't upgrade to OCaml 4.10?

hannesm commented 2 years ago

also, List.concat_map is used in happy_eyeballs.ml, which is available only since OCaml 4.10, and the reason for the lower bound of this project.

hannesm commented 2 years ago

in #18 we have the required code changes, the next release will be compatible with OCaml 4.08. thanks.