search

robur-coop / happy-eyeballs

An implementation of happy eyeballs (RFC 8305) in OCaml with lwt
ISC License
22 stars 4 forks source link

happy-eyeballs: timer always returns an 'action list' #18

Closed hannesm closed 2 years ago

hannesm commented 2 years ago

happy-eyeballs-lwt/happy-eyeballs-mirage: adapt to the API change

//cc @reynir. this should fix #17

hannesm commented 2 years ago

requires https://github.com/mirage/ocaml-dns/pull/274 for the happy-eyeballs-lwt and happy-eyeballs-mirage packages

reynir commented 2 years ago

This looks good, but I am wondering if it would be smart to assert that actions consists only of Connect_failed when we're suspending?

hannesm commented 2 years ago

I don't think that writing that assert() is worth it.