Update the CI system - Githubissues

robur-coop / qubes-miragevpn

BSD 2-Clause "Simplified" License

7 stars 1 forks source link

Update the CI system #2

Closed palainp closed 4 months ago

palainp commented 5 months ago

Dear @dinosaure, Thank you for going into qubes-miragevpn :heart: This PR is a first try to help with the CI system, based on what is done at qubes-mirage-firewall, it:

updates opam-repository to a recent state to have the last happy_eyeballs version
pins two repository that should be removed if PRs can be merged
changes how the hashsum is compared, and avoid shell shenigans that can be hard to follow, sensible and could fail.
also update a bit the code, I had some issues.

Unfortunately the hashsum is not the reproducible value as it's based on my local build. Best.

palainp commented 5 months ago

~~Oups sorry, I missed the correct branch for this PR, is there a way to target the ci branch now?~~

dinosaure commented 5 months ago

Ok the error is unrelated to what you did but some of archives are in our git.robur.coop server and we just got few issue on it. So we can not continue this PR until the server is back.

palainp commented 5 months ago

Ok the error is unrelated to what you did but some of archives are in our git.robur.coop server and we just got few issue on it. So we can not continue this PR until the server is back.

Yes, I saw that, take the time you need and be safe :)

palainp commented 5 months ago

For the time being, I'm keeping the pin on mirage-qubes as it works with the current mirage version (it's pinned as v0.9.X), but it should be removed once mirage-qubes 0.10.0 is merged in opam-repository and a new release for mirage is also integrated.

~~EDIT: I'm afk right now, so to the future me: check the version of this xz package against the late March backdoor. With debian packages from April 19 it should be safe but just in case...~~ EDIT: We use debian stable, and it's currently version 5.4.1 which is not affected :)

palainp commented 4 months ago

Hmm, the hashsum is not the same and I have a shell syntax error in the action script. I'll fix that quickly, sorry for that :(

palainp commented 4 months ago

My local build kept the duniverse folder, I now have the same hashsum as github action :)