robur-coop / udns

[deprecated, developmeht moved to https://github.com/mirage/ocaml-dns] µDNS - an opinionated Domain Name System (DNS) library
BSD 2-Clause "Simplified" License
55 stars 5 forks source link

Client: Handle ANY and CNAME recursion #11

Closed cfcs closed 5 years ago

cfcs commented 5 years ago

ping @hannesm

cfcs commented 5 years ago

ping @hannesm

hannesm commented 5 years ago

CI dislikes:

# File "client/udns_client.ml", line 71, characters 10-13:
# Error: The GADT constructor Any of type Dns_map.k
#        must be qualified in this pattern.

...on 4.06.0... any hints!?

cfcs commented 5 years ago

I'm not smart enough to fix this :-(

cfcs commented 5 years ago

OK with the assistance of qualified help I was smart enough to look at the new Travis job and realize that the previous commit fixed the issue, but now failed due to the use of Seq.t when converting from Map.t to Set.t. I switched to using a list instead. Travis seems green :))))