search

robur-coop / udns

[deprecated, developmeht moved to https://github.com/mirage/ocaml-dns] µDNS - an opinionated Domain Name System (DNS) library
BSD 2-Clause "Simplified" License
55 stars 5 forks source link

fix compilation errors in unikernel examples #2

Closed mneilsen closed 6 years ago

mneilsen commented 6 years ago

With these minor adjustments, all of the unikernel examples compile without errors. Built against Mirage's "unix" target using OCaml 4.06.0.

hannesm commented 6 years ago

Thanks for your PR, @mneilsen - highly appreciated. I develop this library elsewhere, and had these issues already fixed in a separate branch, which I now pushed to GitHub #3. This adds as well TLSA and SSHFP resource records. Since my PR includes your changes, I'll close yours.

hannesm commented 6 years ago

I also added https://github.com/roburio/udns/commit/a5bbd1eead94f4f7ffe935ac24e0444675f74c07 https://github.com/roburio/udns/pull/3/commits/ea8a460008710c27e93d0af23c6aa0484e7d4a34 https://github.com/roburio/udns/pull/3/commits/843a75bdb610011246014d6027f892fde3888c7d which automatically tests all the example unikernels to avoid breaking the examples in the future.