fix dns-client-unix; replace some `cardinal` with `is_empty`

robur-coop / udns

[deprecated, developmeht moved to https://github.com/mirage/ocaml-dns] µDNS - an opinionated Domain Name System (DNS) library

BSD 2-Clause "Simplified" License

55 stars 5 forks source link

fix dns-client-unix; replace some `cardinal` with `is_empty` #30

Closed cfcs closed 5 years ago

cfcs commented 5 years ago

This fixes a build error for dns-client-unix:

# File "_none_", line 1:
# Error: No implementations provided for the following modules:
#          Unix referenced from unix/client/dns_client_unix.cmxa(Dns_client_unix)

And replaces some instances of cardinal t = 0 with is_empty t which imho is easier to read, and easier to reason about performance-wise.

hannesm commented 5 years ago

thanks!