robur-coop / unipi

Serving content from a git repository via HTTPS (including let's encrypt provisioning) as MirageOS unikernel
63 stars 7 forks source link

name all the Runtime_arg being created #30

Closed hannesm closed 6 months ago

hannesm commented 6 months ago

to be honest, I don't know whether we need this or not... - but it looks not nice to have some passing ~name, while others don't... (i.e. ssh_key always passed that name)...

reynir commented 6 months ago

Runtime_arg.create is undocumented (!?) and I can't quite figure out what name is used for except as an identifier in generated code (maybe). I'll open an issue on mirage/mirage. In the meantime I'm not able to properly review this...

hannesm commented 6 months ago

since that will change in 4.5.1, we'll remove these names.