search

robust-rosin / robust

A dataset of 200+ bugs in the Robot Operating System for BugZoo
30 stars 10 forks source link

Update build-rosinstall.py to support new time machine #172

Closed ChrisTimperley closed 5 years ago

gavanderhoorn commented 5 years ago

Sorry, haven't finished it yet .. :(

ChrisTimperley commented 5 years ago

Sorry, haven't finished it yet .. :(

Ah, no worries. Do you expect the interface to be any different to the one used by https://github.com/rosin-project/rosinstall_generator_time_machine/pull/8?

gavanderhoorn commented 5 years ago

No.

Or at least not significantly.

If/when the Python version gets here the ros distro arg might need a --rosdistro= prepended and the timestamp a --timestamp, but that's about it I think.

ChrisTimperley commented 5 years ago

No.

Or at least not significantly.

If/when the Python version gets here the ros distro arg might need a --rosdistro= prepended and the timestamp a --timestamp, but that's about it I think.

Great. Do you mind if I go ahead and update build-bugzoo.py to support https://github.com/rosin-project/rosinstall_generator_time_machine/pull/8?

gavanderhoorn commented 5 years ago

No, go ahead.

As long as it's clear that people need the PR. And not the current master.

Perhaps you could make build-bugzoo.py check for presence of the Docker image the new version uses?

gavanderhoorn commented 5 years ago

Time machine was upgraded, so master branch of that repository now contains the new version.

Docker image is now also v03.