Fixed phase for "f2568f5" to be "startup" rather than "runtime"

robust-rosin / robust

A dataset of 200+ bugs in the Robot Operating System for BugZoo

30 stars 10 forks source link

Fixed phase for "f2568f5" to be "startup" rather than "runtime" #367

Closed ChrisTimperley closed 4 years ago

gavanderhoorn commented 4 years ago

I'm happy to take a look, but could you please provide your rationale for why you'd want to change it to startup?

ChrisTimperley commented 4 years ago

Sure. The rationale is that the missing Python runtime dependency will lead to an ImportError exception whenever tf2_sensor_msgs is imported. Imports overwhelming take place during start-up in Python, and performing imports inside of method calls, for instance, is considered poor form.