search

robust-rosin / robust

A dataset of 200+ bugs in the Robot Operating System for BugZoo
30 stars 10 forks source link

Fixed YAML markup for geometry2 bugs #371

Closed ChrisTimperley closed 4 years ago

gavanderhoorn commented 4 years ago

Looks ok, but I'm curious what Yamale thinks of the geometry2 bugs now.

@ipa-hsd ?

Could you perhaps run Yamale against the geometry2 sub dir?

hsd-dev commented 4 years ago

Tested it for 3ec0485.bug

Error validating data '../geometry2/3ec0485/3ec0485.bug' with './robust.yaml'

    failure-codes: Required field missing
    fault-codes: Required field missing
    bug.package: 'ros/geometry2/tf2_ros' is not a list.
    bug.reported-by: 'member-developer' not in ('guest user', 'contributor', 'member developer', 'automatic', 'unreported')
    bug.time-reported: 'N/A' is not a date.
    bug.time-reported: 'N/A' is not a null.
    fix.license: 'BSD' is not a list.
    fix.time: '2015-05-10 21:11 GMT+2' is not a date.
    fix.time: '2015-05-10 21:11 GMT+2' is not a null.
ChrisTimperley commented 4 years ago

Fixed licenses with:

find . -name *.bug | xargs -n1 sed -i "s/license: BSD/license: ['BSD']/g"

I manually checked with grep that the command above wouldn't break the files in other places:

grep "license: BSD" . -r
ChrisTimperley commented 4 years ago

If there's no objections, @gavanderhoorn, @ipa-hsd, let's go ahead and merge this into master and leave yamale/schema-related things out of this PR.

gavanderhoorn commented 4 years ago

Sure, I was just curious.