robust-rosin / robust

A dataset of 200+ bugs in the Robot Operating System for BugZoo
30 stars 10 forks source link

turtlebot/3ea2c30: liveness seems far fetched #429

Closed gavanderhoorn closed 3 years ago

gavanderhoorn commented 3 years ago

turtlebot/3ea2c30 is labelled SOFTWARE:LIVENESS. This seems hard to justify given the description:

https://github.com/robust-rosin/robust/blob/93afbcb2ed1e74a9fbfa8eef7c2293ec8526f8d6/turtlebot/3ea2c30/3ea2c30.bug#L4-L14

The user reporting the bug essentially describes he gets a warning, but does not mention any loss of functionality, nor any components which fail to function properly.

He's not using the components which depend on the bit of script which is not working (ie: the environment hook): the navigation stack would depend on the TURTLEBOT_MAP_FILE env var being set, but he doesn't use it.

LOSS-OF-CONTROL is even harder to justify: if this were a completely automated system, the map not being configured for the navigation stack could certainly lead to the robot not being able to navigate, but it would not even start up (ie: it would never have control, so it can't lose it).

gavanderhoorn commented 3 years ago

Apparently I'd already posted this.

Closing as a duplicate of #415.