Resolve whether bug leads to a crash or incorrect behavior at runtime

robust-rosin / robust

A dataset of 200+ bugs in the Robot Operating System for BugZoo

30 stars 10 forks source link

Resolve whether bug leads to a crash or incorrect behavior at runtime #446

Open ChrisTimperley opened 3 years ago

ChrisTimperley commented 3 years ago

Relevant bug: geometry2/1b5fa94/1b5fa94.bug

@gavanderhoorn we're unsure whether this leads to either: (a) a crash at run-time, or (b) using a meaningless/corrupted transform. If the former, then we should go with LOSS-OF-FUNCTIONALITY. If the latter, we should go with BEHAVING-INCORRECTLY.

_Originally posted by @ChrisTimperley in https://github.com/robust-rosin/robust/pull/430#discussion_r678371955_

ChrisTimperley commented 3 years ago

@gavanderhoorn @ipa-hsd I've moved this issue to here.

gavanderhoorn commented 3 years ago

If I understand 1b5fa94 correctly, it would lead to a memory leak.

So (at a high-level): if any Python node which uses TF2 runs for a sufficient amount of time, it will run out of memory and crash.

From the linked PR:

I have found a memory leak in tf2_py.cpp [..] Whit this fix the memory leak is fixed. We have experience this memory leak when having robots working during days.

gavanderhoorn commented 3 years ago

Btw: it looks like https://github.com/ros/geometry2/issues/258 is the issue which reported this (although it was reported by a different user).

Perhaps we should update the .bug?