search

robusta-dev / homebrew-krr

Homebrew repository for installing KRR with brew
MIT License
0 stars 2 forks source link

Cannot upgrade krr to version 1.10.0 #4

Open aazon opened 3 weeks ago

aazon commented 3 weeks ago

Hello,

My brew cannot upgrade krr from version 1.8.3 to the version 1.10.0.

As far as I can understand, the error happens here:

==> Running 'krr version' to warm up binary and extract compressed python libraries... this can take up to 60 seconds
==> /usr/local/Cellar/krr/1.10.0/libexec/krr version
Failed to execute: /usr/local/Cellar/krr/1.10.0/libexec/krr

Here is the full output:

% brew upgrade --verbose
==> Upgrading 1 outdated package:
robusta-dev/krr/krr 1.8.3 -> 1.10.0
==> Fetching robusta-dev/krr/krr
==> Downloading https://github.com/robusta-dev/krr/releases/download/v1.10.0/krr-macos-latest-v1.10.0.zip
Already downloaded: /Users/aazon/Library/Caches/Homebrew/downloads/10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip
==> Verifying checksum for '10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip'
==> Upgrading robusta-dev/krr/krr
  1.8.3 -> 1.10.0
rm /usr/local/bin/krr
/usr/bin/env PATH=/usr/local/Homebrew/Library/Homebrew/shims/mac/super:/usr/bin:/bin:/usr/sbin:/sbin unzip -o /Users/aazon/Library/Caches/Homebrew/downloads/10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip -d /private/tmp/homebrew-unpack20240614-85866-jf2v7l
/usr/bin/env cp -pR /private/tmp/homebrew-unpack20240614-85866-jf2v7l/krr/. /private/tmp/krr-20240614-85866-uhfuqd/krr
==> Running 'krr version' to warm up binary and extract compressed python libraries... this can take up to 60 seconds
==> /usr/local/Cellar/krr/1.10.0/libexec/krr version
Failed to execute: /usr/local/Cellar/krr/1.10.0/libexec/krr
ln -s ../Cellar/krr/1.8.3/bin/krr krr

==> Formula
Tap: robusta-dev/krr
Path: /usr/local/Homebrew/Library/Taps/robusta-dev/homebrew-krr/Formula/krr.rb
==> Configuration
HOMEBREW_VERSION: 4.3.5-95-g24f74c0
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: 24f74c05280870be60168ed7287789e59b9e4ff9
Last commit: 6 hours ago
Core tap HEAD: 39c4d9bb45d8d1e993be50a46390cad92dbabda3
Core tap last commit: 2 hours ago
Core tap JSON: 14 Jun 09:26 UTC
Core cask tap HEAD: 5d6faad7cfec3b34f25251c2792ab9025807a08f
Core cask tap last commit: 2 hours ago
Core cask tap JSON: 14 Jun 09:26 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_AUTO_UPDATE_SECS: 86400
HOMEBREW_CASK_OPTS: []
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 12
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.3.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.3/bin/ruby
CPU: dodeca-core 64-bit kabylake
Clang: 15.0.0 build 1500
Git: 2.45.2 => /usr/local/bin/git
Curl: 8.6.0 => /usr/bin/curl
macOS: 14.5-x86_64
CLT: 15.3.0.0.1.1708646388
Xcode: 15.4
==> ENV
HOMEBREW_CC: clang
HOMEBREW_CXX: clang++
MAKEFLAGS: -j12
CMAKE_PREFIX_PATH: /usr/local
CMAKE_INCLUDE_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/14
HOMEBREW_GIT: git
HOMEBREW_SDKROOT: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk
ACLOCAL_PATH: /usr/local/share/aclocal
PATH: /usr/local/Homebrew/Library/Homebrew/shims/mac/super:/usr/bin:/bin:/usr/sbin:/sbin

Error: robusta-dev/krr/krr 1.10.0 did not build
Logs:
     /Users/aazon/Library/Logs/Homebrew/krr/00.options.out
     /Users/aazon/Library/Logs/Homebrew/krr/01.krr
If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
  https://github.com/robusta-dev/homebrew-krr/issues

I tried to reinstall krr but got the same error message.

aantn commented 3 weeks ago

Strange, if you completely uninstall and then reinstall does it succeed?

aazon commented 3 weeks ago

Uninstall and reinstall don't help:

% brew uninstall krr -v
Uninstalling /usr/local/Cellar/krr/1.8.3... (2,614 files, 320.4MB)
rm /usr/local/bin/krr
% brew cleanup
...
Removing: /Users/aazon/Library/Caches/Homebrew/XXX
Removing: /Users/aazon/Library/Caches/Homebrew/YYY
...
Pruned 0 symbolic links and 2 directories from /usr/local
==> This operation has freed approximately 215.6MB of disk space.

Now trying to install krr again:

% brew install krr -v
==> Fetching robusta-dev/krr/krr
==> Downloading https://github.com/robusta-dev/krr/releases/download/v1.10.0/krr-macos-latest-v1.10.0.zip
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/603117527/36ab9ebd-a79e-4154-8771-df5a564ab747?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=releaseassetproduction%2F20240614%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240614T111010Z&X-Amz-Expires=300&X-Amz-Signature=8b6360952331cbaeb504590792db0b468d3b52154244554ce45672d948889ba3&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=603117527&response-content-disposition=attachment%3B%20filename%3Dkrr-macos-latest-v1.10.0.zip&response-content-type=application%2Foctet-stream
/usr/bin/env /usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.3.5-95-g24f74c0\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 14.5\)\ curl/8.6.0 --header Accept-Language:\ en --fail --retry 3 --remote-time --output /Users/aazon/Library/Caches/Homebrew/downloads/10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip.incomplete --location https://objects.githubusercontent.com/github-production-release-asset-2e65be/603117527/36ab9ebd-a79e-4154-8771-df5a564ab747\?X-Amz-Algorithm=AWS4-HMAC-SHA256\&X-Amz-Credential=releaseassetproduction\%2F20240614\%2Fus-east-1\%2Fs3\%2Faws4_request\&X-Amz-Date=20240614T111010Z\&X-Amz-Expires=300\&X-Amz-Signature=8b6360952331cbaeb504590792db0b468d3b52154244554ce45672d948889ba3\&X-Amz-SignedHeaders=host\&actor_id=0\&key_id=0\&repo_id=603117527\&response-content-disposition=attachment\%3B\%20filename\%3Dkrr-macos-latest-v1.10.0.zip\&response-content-type=application\%2Foctet-stream
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 82.2M  100 82.2M    0     0  6431k      0  0:00:13  0:00:13 --:--:-- 6688k
==> Verifying checksum for '10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip'
==> Installing krr from robusta-dev/krr
/usr/bin/env PATH=/usr/local/Homebrew/Library/Homebrew/shims/mac/super:/usr/bin:/bin:/usr/sbin:/sbin unzip -o /Users/aazon/Library/Caches/Homebrew/downloads/10f7fd854de52a19a9b2b0ade2bbbde764225eab1666d66222c2f775023fc60d--krr-macos-latest-v1.10.0.zip -d /private/tmp/homebrew-unpack20240614-2598-f4jkx9
/usr/bin/env cp -pR /private/tmp/homebrew-unpack20240614-2598-f4jkx9/krr/. /private/tmp/krr-20240614-2598-bd2e0e/krr
==> Running 'krr version' to warm up binary and extract compressed python libraries... this can take up to 60 seconds
==> /usr/local/Cellar/krr/1.10.0/libexec/krr version
Failed to execute: /usr/local/Cellar/krr/1.10.0/libexec/krr

==> Formula
Tap: robusta-dev/krr
Path: /usr/local/Homebrew/Library/Taps/robusta-dev/homebrew-krr/Formula/krr.rb
==> Configuration
HOMEBREW_VERSION: 4.3.5-95-g24f74c0
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: 24f74c05280870be60168ed7287789e59b9e4ff9
Last commit: 8 hours ago
Core tap HEAD: 39c4d9bb45d8d1e993be50a46390cad92dbabda3
Core tap last commit: 4 hours ago
Core tap JSON: 14 Jun 11:05 UTC
Core cask tap HEAD: 5d6faad7cfec3b34f25251c2792ab9025807a08f
Core cask tap last commit: 4 hours ago
Core cask tap JSON: 14 Jun 11:05 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_AUTO_UPDATE_SECS: 86400
HOMEBREW_CASK_OPTS: []
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 12
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.3.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.3/bin/ruby
CPU: dodeca-core 64-bit kabylake
Clang: 15.0.0 build 1500
Git: 2.45.2 => /usr/local/bin/git
Curl: 8.6.0 => /usr/bin/curl
macOS: 14.5-x86_64
CLT: 15.3.0.0.1.1708646388
Xcode: 15.4
==> ENV
HOMEBREW_CC: clang
HOMEBREW_CXX: clang++
MAKEFLAGS: -j12
CMAKE_PREFIX_PATH: /usr/local
CMAKE_INCLUDE_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/14
HOMEBREW_GIT: git
HOMEBREW_SDKROOT: /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk
ACLOCAL_PATH: /usr/local/share/aclocal
PATH: /usr/local/Homebrew/Library/Homebrew/shims/mac/super:/usr/bin:/bin:/usr/sbin:/sbin

Error: robusta-dev/krr/krr 1.10.0 did not build
Logs:
     /Users/aazon/Library/Logs/Homebrew/krr/00.options.out
     /Users/aazon/Library/Logs/Homebrew/krr/01.krr
If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
  https://github.com/robusta-dev/homebrew-krr/issues

These open issues may also help:
Cannot upgrade krr to version 1.10.0 https://github.com/robusta-dev/homebrew-krr/issues/4
aantn commented 3 weeks ago

Can you try downloading the same release from GitHub using the cli (copy the url from the releases page and download it with curl -L <url> -o krr.zip then unzip it, cd into the directory, run it, and share logs?

It's important that you do NOT download with the browser as the binaries are unsigned and Mac OS quarantines browser downloaded binaries.

bearnard commented 2 weeks ago

fwiw, seems like the macos builds are only for Apple silicon (arm64).

$ ./krr/krr simple 
-bash: ./krr/krr: Bad CPU type in executable
$ file ./krr/krr
./krr/krr: Mach-O 64-bit executable arm64
bearnard commented 2 weeks ago

related: https://github.com/actions/runner-images/issues/9741

aantn commented 2 weeks ago

Yes, that's right. Is building binaries for Mac OS x86 just a matter of using an older non-ARM image? Is there an image on which we can build a universal binary or does it have to be separate builds?

aazon commented 2 weeks ago

I tried to download a binary using curl command but got an error in the end:

% curl -L https://github.com/robusta-dev/krr/releases/download/v1.11.0/krr-macos-latest-v1.11.0.zip -o krr-macos-latest-v1.11.0.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 82.2M  100 82.2M    0     0  6145k      0  0:00:13  0:00:13 --:--:-- 6372k

Then I tried to execute the krr binary:

% ./krr --help
zsh: bad CPU type in executable: ./krr
aantn commented 2 weeks ago

What architecture are you on? I think we are only building ARM binaries right now.

aazon commented 2 weeks ago

I have Intel MacBook

aantn commented 2 weeks ago

Got it. I've opened a PR to build binaries for x86 starting from the next release.

https://github.com/robusta-dev/krr/pull/302/files

Until then, are you able to run from source or via the Docker image?