search

robusta-dev / kubewatch

Watch k8s events and trigger Handlers
Apache License 2.0
547 stars 79 forks source link

Slack messages for updates don't include namespace in the message #20

Closed CapKenR closed 1 year ago

CapKenR commented 1 year ago

Notice the `` in the example update message below.

kubewatch
A pod in namespace `` has been updated:
vmware-system-tmc/agentupdater-workload-1674792840-kk7b4

However, it is a bit redundant as the resource name includes the namespace.

Notice the example create and delete messages below include the namespace in the message.

kubewatch
A job in namespace vmware-system-tmc has been created:
agentupdater-workload-1674792900
kubewatch
A job in namespace vmware-system-tmc has been deleted:
vmware-system-tmc/agentupdater-workload-1674792780
arikalon1 commented 1 year ago

Thanks @CapKenR There are a few inconsistencies here, with the message formats for the different resources and operations. We need to align it

RoiGlinik commented 1 year ago

@CapKenR this is fixed in https://github.com/robusta-dev/kubewatch/pull/24 and included in the new v2.1.0