search

robusta-dev / kubewatch

Watch k8s events and trigger Handlers
Apache License 2.0
604 stars 84 forks source link

Default false for all notification channels #41

Closed bkvtin closed 1 year ago

bkvtin commented 1 year ago

Hi, i think we should set false for all notification channels, example when configuring with msteam, I am not aware slack default true so need to check logs to debug issue

arikalon1 commented 1 year ago

Thanks for your PR @bkvtin

Changing the default behavior in such a way is not backward compatible. As such it may cause issues on the next upgrades, for users that use the default configuration.

We try not to break the existing behavior.