robusta-dev / robusta

Kubernetes observability and automation, with an awesome Prometheus integration
https://home.robusta.dev/
MIT License
2.59k stars 253 forks source link

template_enricher can't handle label app.kubernetes.io/name #1316

Open zmx opened 7 months ago

zmx commented 7 months ago

Describe the bug K8s Pod create by Argo CD will have label app.kubernetes.io/name The KubernetesResourceEvent have that label, but string.Template.safe_substitute can't handle dot and slash

To Reproduce

$ kubectl get pod cert-manager-758c6b68ff-v2zwl -n cert-manager -o yaml
apiVersion: v1
kind: Pod
metadata:
  annotations:
    prometheus.io/path: /metrics
    prometheus.io/port: "9402"
    prometheus.io/scrape: "true"
  creationTimestamp: "2023-11-16T22:55:04Z"
  generateName: cert-manager-758c6b68ff-
  labels:
    app: cert-manager
    app.kubernetes.io/component: controller
    app.kubernetes.io/instance: cert-manager
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: cert-manager
    app.kubernetes.io/version: v1.11.2
    azure.workload.identity/use: "true"
    helm.sh/chart: cert-manager-v1.11.2

Expected behavior template could handle ${app.kubernetes.io/name}

github-actions[bot] commented 7 months ago

Hi 👋, thanks for opening an issue! Please note, it may take some time for us to respond, but we'll get back to you as soon as we can!

zmx commented 7 months ago

https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels It is Recommended Labels

zmx commented 3 months ago

looks like resolved by #1389

zmx commented 3 months ago

https://github.com/robusta-dev/robusta/pull/1492