search

robusta-dev / robusta

Kubernetes observability and automation, with an awesome Prometheus integration
https://home.robusta.dev/
MIT License
2.57k stars 252 forks source link

Fix/zulip block formatting #1404

Closed oscgu closed 4 months ago

oscgu commented 5 months ago

The last arg in __to_zulip_block() should be the format, if anything, or else you end up with unreadable messages

oscgu commented 4 months ago

Thanks @oscgu , looks good

Unrelated to this fix, but why are you using yield?

IMO it makes it easier to return 1..N strings from the func, without the need for some sort of temporary list. The performance difference should be negligible too. Should I have implemented it differently?