search

robusta-dev / robusta

Kubernetes observability and automation, with an awesome Prometheus integration
https://home.robusta.dev/
MIT License
2.57k stars 252 forks source link

add promtheus labels to slack message #1433

Closed romga closed 4 months ago

wrbbz commented 4 months ago

But why?

romga commented 4 months ago

But why?

@wrbbz can you please elaborate?

wrbbz commented 4 months ago

What for do we need prom labels in slack message? As I think, it is a little bit excessive information. Am I wrong?

romga commented 4 months ago

@wrbbz i am using the labels in order to decide which alert sent to which channel :)

wrbbz commented 4 months ago

Why not use kubernetes labels?

Nevertheless, they will be shown in aggregation key

On the other hand, I would suggest more dynamic message creation. If there are some labels - we add labels in the message, if none - no mention at all (instead of None). It could be misleading. I would have decided, that there is an issue with some data absence if I see None