search

robusta-dev / robusta

Kubernetes observability and automation, with an awesome Prometheus integration
https://home.robusta.dev/
MIT License
2.5k stars 247 forks source link

MailSender: findings_header, investigate link and source should be optional #1454

Open tabea-kinexon opened 3 weeks ago

tabea-kinexon commented 3 weeks ago

Is your feature request related to a problem?

Yes. I need to have full control over the email content that is being sent. e.g.: The emails might go to people that do not have access to the Robusta platform. So sending emails with that link will be more confusing than helpful.

Describe the solution you'd like

Add a config parameter to the emailSink (e.g. robustaFindingsEnrichment). Default can be true, however, if set to false only content added by enrichers/actions is added to the email.

Describe alternatives you've considered Remove the custom blocks from the send_finding method in the MailSender and offer it as an enrichment

github-actions[bot] commented 3 weeks ago

Hi 👋, thanks for opening an issue! Please note, it may take some time for us to respond, but we'll get back to you as soon as we can!

aantn commented 3 weeks ago

Hey, thanks for opening an issue. I had a question about your use case, as we've started to roll out RBAC on the SaaS platform on our paid plans. Does RBAC mitigate the need for this in any way?

We're happy to accept a PR for not sending the platform links of course, but if we could solve this by giving those people limited access, maybe that is a better outcome.

tabea-kinexon commented 2 weeks ago

Hey,

unfortunately I do not want the people I send this emails to, to have access to it at all. I will see if I find time to code a solution and create a PR this month.

aantn commented 2 weeks ago

Sounds good. Is there any content that those people should see? Curious to learn more on the motivation for limiting it, as it may help us improve the product.