search

robusta-dev / robusta

Better Prometheus alerts for Kubernetes - smart grouping, AI enrichment, and automatic remediation
https://home.robusta.dev/
MIT License
2.62k stars 260 forks source link

Some alerts or alert types are missing fingerprint #517

Closed taivo123 closed 2 years ago

taivo123 commented 2 years ago

Describe the bug Some alerts or alert types are missing fingerprint. It is possible, that KUBERNETES_API_SERVER sourced alarms are missing the fingerprint, but PROMETHEUS sourced alarms have it Some examples with missing fingerprint:

To Reproduce Steps to reproduce the behavior:

  1. generate Updates to significant fields alert (for example with resource_babysitter action)
  2. observe how the fingerprint field is missing (for example with print(f"fingerprint ::: {finding.fingerprint} "))

Expected behavior Expecting fingerprint to be present for most, if not all alerts

aantn commented 2 years ago

I wonder if we should be including the cluster name in the hash too. #525 implies that the cluster name needs to be included in the hash for OpsGenie.