Palo Alto devtype mismatch

BrianCanFixIT commented 1 year ago

Based upon a code review, the "set" output type, cased as devtype 5 will not trigger and that a devtype of 7 will potentially fail. Myabe the set devtype is supposed to be 7?

  if (($dev.devtype -eq 6) -or ($dev.devtype -eq 7)) {
    # DEVTYPE 6 or 7 - PALO ALTO FIREWALL, backup two ways
    if ($dev.devtype -eq 5) { $outcmd = "set cli config-output-format set`n" ; $outtype = "set"}
    if ($dev.devtype -eq 6) { $outcmd = "set cli config-output-format xml`n" ; $outtype = "xml" }

robvandenbrink commented 1 year ago

Yes, a simple typo, thanks! I'll get it fixed

From: Brian Rose @.> Sent: Thursday, January 5, 2023 12:30 PM To: robvandenbrink/rtrbk @.> Cc: Subscribed @.***> Subject: [robvandenbrink/rtrbk] Palo Alto devtype mismatch (Issue #2)

Based upon a code review, the "set" output type, cased as devtype 5 will not trigger and that a devtype of 7 will potentially fail. Myabe the set devtype is supposed to be 7?

if (($dev.devtype -eq 6) -or ($dev.devtype -eq 7)) {

# DEVTYPE 6 or 7 - PALO ALTO FIREWALL, backup two ways

if ($dev.devtype -eq 5) { $outcmd = "set cli config-output-format set`n" ; $outtype = "set"}

if ($dev.devtype -eq 6) { $outcmd = "set cli config-output-format xml`n" ; $outtype = "xml" }

- Reply to this email directly, view it on GitHubhttps://github.com/robvandenbrink/rtrbk/issues/2, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD7CAU33FOHWZGB3NXURVHLWQ4AKXANCNFSM6AAAAAATSGKMSY. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

robvandenbrink commented 1 year ago

Updated on git, give it a try now? Thanks again!

From: Brian Rose @.> Sent: Thursday, January 5, 2023 12:30 PM To: robvandenbrink/rtrbk @.> Cc: Subscribed @.***> Subject: [robvandenbrink/rtrbk] Palo Alto devtype mismatch (Issue #2)

Based upon a code review, the "set" output type, cased as devtype 5 will not trigger and that a devtype of 7 will potentially fail. Myabe the set devtype is supposed to be 7?

if (($dev.devtype -eq 6) -or ($dev.devtype -eq 7)) {

# DEVTYPE 6 or 7 - PALO ALTO FIREWALL, backup two ways

if ($dev.devtype -eq 5) { $outcmd = "set cli config-output-format set`n" ; $outtype = "set"}

if ($dev.devtype -eq 6) { $outcmd = "set cli config-output-format xml`n" ; $outtype = "xml" }

- Reply to this email directly, view it on GitHubhttps://github.com/robvandenbrink/rtrbk/issues/2, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD7CAU33FOHWZGB3NXURVHLWQ4AKXANCNFSM6AAAAAATSGKMSY. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

robvandenbrink commented 1 year ago

robvandenbrink / rtrbk

Palo Alto devtype mismatch #2