search

robvanmieghem / gominer

GPU miner for siacoin in go
BSD 2-Clause "Simplified" License
159 stars 75 forks source link

miner.minerCount doesn't take into consideration excluded GPU #12

Closed antoninblanc closed 8 years ago

antoninblanc commented 8 years ago

In miner.go, nrOfMiningDevices is defined as nrOfMiningDevices := len(clDevices) then few lines after, the for loop handle deviceExcludedForMining.

This cause incorrect work.Offset

work.Offset += uint64(miner.GlobalItemSize) * uint64(miner.minerCount)

Sorry for not giving a push request, first time i read Go code !

robvanmieghem commented 8 years ago

Can you point me to the exact line of code where you see work.Offset += uint64(miner.GlobalItemSize) * uint64(miner.minerCount) ?

I have a suspicion you are reading the code from a fork that has been modified in a suboptimal way.

antoninblanc commented 8 years ago

uups my bad, indeed wrong github depot. I was using the SiaMining fork https://github.com/SiaMining/gominer/blob/poolmod3/miner.go#L104

You can close this ticket. I'll open an issue there.

For info you have a pool request https://github.com/robvanmieghem/gominer/pull/10 with the that code https://github.com/robvanmieghem/gominer/pull/10/commits/07c53416dc7fe2eb05bfb0f3d38772b7aeba42ca#diff-02219c16ae62ec873619f6118d759f1bR104

EDIT : I can't find how to open ticket on the SiaMining fork...

robvanmieghem commented 8 years ago

@antoninblanc looks like they turned that off in the repository settings