robvdpol / RaceControl

Race Control is a standalone, open source F1TV client for Windows, written in C# on the .NET platform.
GNU General Public License v3.0
1.19k stars 95 forks source link

[BUG] F1 Live channel no longer picked up by application due to internal name change #387

Closed eXhumer closed 2 years ago

eXhumer commented 2 years ago

Describe the bug F1 Live channel is now called "F1 LIVE" internally instead of "PIT LANE". As a result, RaceControl can't pick it up due to hardcoded detection used by RaceControl (https://github.com/robvdpol/RaceControl/blob/master/RaceControl/RaceControl.Common/Constants/ChannelNames.cs#L6)

To Reproduce Steps to reproduce the behavior:

  1. Go to 2022 Season, Saudi Arabia Grand Prix, Practice 1 and try to locate F1 Live channel. It is missing.

Expected behavior F1 Live channel to appear as it does in F1TV website.

Screenshots image

Desktop (please complete the following information):

F1TV account

Additional context Add any other context about the problem here.

eXhumer commented 2 years ago

It appears to be related to change that happened to /CONTENT/VIDEO, it was updated to 3.0 while the application is still using 2.0 endpoint. 2.0 doesn't seem to return F1 Live channel in additionalStreams object at all anymore.

robvdpol commented 2 years ago

I will change it to 3.0, was already planning to do so.

robvdpol commented 2 years ago

Should be fixed by e047d92599ddf25af7ffb03a755b2877e12db2c7